Prometheus Metrics Instrumentation (Feature #218) #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmveeresh
requested review from
crivetimihai,
kevalmahajan and
madhav165
as code owners
rakdutta
requested changes
Oct 27, 2025
rakdutta
force-pushed
the
feature/218-prometheus-metrics-instrumentation
branch
from
8ddbed7 to
805e7ef
Compare
|
Updated the document and include the endpoint in the OpenAPI schema so it appears in Swagger UI. |
rakdutta
approved these changes
Oct 27, 2025
Signed-off-by: Veeresh K <[email protected]>
Signed-off-by: Veeresh K <[email protected]>
Signed-off-by: Veeresh K <[email protected]>
Signed-off-by: Veeresh K <[email protected]>
Signed-off-by: Veeresh K <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Add comprehensive documentation for Prometheus metrics configuration variables to .env.example: - ENABLE_METRICS: Toggle metrics collection (default: true) - METRICS_EXCLUDED_HANDLERS: Regex patterns for endpoint exclusion - METRICS_NAMESPACE: Metrics name prefix (default: "default") - METRICS_SUBSYSTEM: Secondary metrics prefix - METRICS_CUSTOM_LABELS: Static labels for app_info gauge Includes examples, security warnings about high-cardinality labels, and formatting consistent with existing configuration sections. Related to PR #1313 Signed-off-by: Mihai Criveti <[email protected]>
Signed-off-by: Mihai Criveti <[email protected]>
crivetimihai
force-pushed
the
feature/218-prometheus-metrics-instrumentation
branch
from
805e7ef to
6c829fc
Compare
crivetimihai
approved these changes
Oct 29, 2025
crivetimihai
deleted the
feature/218-prometheus-metrics-instrumentation
branch
Merged
ppippi-dev
added a commit
to ppippi-dev/mcp-context-forge
that referenced
this pull request
Nov 3, 2025
PR IBM#1313 added metrics configuration to values.yaml but did not update values.schema.json, causing helm template validation to fail with: 'Additional property metrics is not allowed' This commit adds the metrics property definition to the schema including: - enabled: boolean to toggle metrics collection - port: integer for metrics endpoint port - serviceMonitor: object for Prometheus Operator integration - customLabels: object for custom metric labels Fixes schema validation error introduced in PR IBM#1313 Related to Feature IBM#218 (Prometheus Metrics Instrumentation) Signed-off-by: ppippi <[email protected]>
ppippi-dev
added a commit
to ppippi-dev/mcp-context-forge
that referenced
this pull request
Nov 3, 2025
PR IBM#1313 added metrics configuration to values.yaml but did not update values.schema.json, causing helm template validation to fail with: 'Additional property metrics is not allowed' This commit adds the metrics property definition to the schema including: - enabled: boolean to toggle metrics collection - port: integer for metrics endpoint port - serviceMonitor: object for Prometheus Operator integration - customLabels: object for custom metric labels Fixes schema validation error introduced in PR IBM#1313 Related to Feature IBM#218 (Prometheus Metrics Instrumentation) Signed-off-by: ppippi-dev <[email protected]>
crivetimihai
pushed a commit
that referenced
this pull request
Nov 4, 2025
…1382) PR #1313 added metrics configuration to values.yaml but did not update values.schema.json, causing helm template validation to fail with: 'Additional property metrics is not allowed' This commit adds the metrics property definition to the schema including: - enabled: boolean to toggle metrics collection - port: integer for metrics endpoint port - serviceMonitor: object for Prometheus Operator integration - customLabels: object for custom metric labels Fixes schema validation error introduced in PR #1313 Related to Feature #218 (Prometheus Metrics Instrumentation) Signed-off-by: ppippi-dev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Enable unified Prometheus-compatible metrics across all FastAPI services for observability, SLO tracking, and proactive alerting.
🧩 Key Changes
mcpgateway/services/metrics.pyto configure Prometheus metrics instrumentation usingprometheus-fastapi-instrumentator.http_requests_total: Request count by method, endpoint, and status code.http_request_duration_seconds: Latency histogram (buckets: 0.05, 0.1, 0.3, 1, 3, 5).http_request_size_bytesandhttp_response_size_bytes: Request and response size histograms./metrics/prometheus.app_infogauge withMETRICS_CUSTOM_LABELSfor cluster-level filtering.METRICS_EXCLUDED_HANDLERSregex.ENABLE_METRICS(default: true)METRICS_EXCLUDED_HANDLERSMETRICS_NAMESPACE,METRICS_SUBSYSTEMMETRICS_CUSTOM_LABELS⚙️ Env Example
✅ Acceptance Criteria
/metrics/prometheusreturns 200 OK and includes standard Prometheus metrics.🧪 Testing
Unit and E2E tests added for: